Re: Hash join explain is broken

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Alexander Korotkov <a.korotkov@postgrespro.ru>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2019-07-02T14:50:02Z
Lists: pgsql-hackers
I wrote:
> Andres Freund <andres@anarazel.de> writes:
>> Tom, any comments? Otherwise I'll go ahead, and commit after a round or
>> two of polishing.

> Sorry for not getting to this sooner --- I'll try to look tomorrow.

I took a look, and I think this is going in the right direction.
We definitely need a test case corresponding to the live bug,
and I think the comments could use more work, and there are some
cosmetic things (I wouldn't add the new struct Hash field at the
end, for instance).

			regards, tom lane



Commits

  1. Fix representation of hash keys in Hash/HashJoin nodes.