Horton

Re: Add Postgres module info

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Euler Taveira" <euler@eulerto.com>
Cc: "Robert Haas" <robertmhaas@gmail.com>, "Andrei Lepikhov" <lepihov@gmail.com>, "Michael Paquier" <michael@paquier.xyz>, "Alexander Korotkov" <aekorotkov@gmail.com>, "Yurii Rashkovskii" <yrashk@omnigres.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-03-24T18:24:34Z
Lists: pgsql-hackers 
"Euler Taveira" <euler@eulerto.com> writes:
> I think those modules without control file, it is natural to use PG_VERSION.
> However, I'm concerned that users can confuse the version if we provide
> PG_VERSION as version and the extension catalog says something different.

Maybe, but the values will be sufficiently different that I don't
think the confusion will last long.  Anyway I don't want the version
in an extension's module to mean something totally different than
the version in a non-extension module.  I could possibly get behind
setting version = PG_VERSION and having another field "ext_version"
or such that shows the expected current extension version if the
module belongs to an extension.  I'm not really convinced it's worth
the trouble, though.

			regards, tom lane

Commits

  1. Avoid mixing designated and non-designated field initializers.

  2. Use PG_MODULE_MAGIC_EXT in our installable shared libraries.

  3. Introduce PG_MODULE_MAGIC_EXT macro.