Horton

Re: BUG #17800: ON CONFLICT DO UPDATE fails to detect incompatible fields that leads to a server crash

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2023-02-24T23:49:10Z
Lists: pgsql-bugs 
Andres Freund <andres@anarazel.de> writes:
> On 2023-02-24 17:12:43 -0500, Tom Lane wrote:
>> I did the renaming you had comments suggesting, but perhaps you want
>> to bikeshed those names?

> Not really. I guess it'd be mildly nicer to have Expr somewhere in the name,
> but whatever.

Maybe Exec{Create|Push}ExprSetupSteps?

> The "don't bother" comment looks a bit lonely now :)

I figured it was important to leave a note that that was intentional.
Doesn't have to look exactly like that, though.

			regards, tom lane

Commits

  1. Fix MULTIEXPR_SUBLINK with partitioned target tables, yet again.

  2. Repair rare failure of MULTIEXPR_SUBLINK subplans in inherited updates.