Horton

Re: Bugs in ecpg's macro mechanism

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2024-04-16T01:33:34Z
Lists: pgsql-hackers 
Andres Freund <andres@anarazel.de> writes:
> On 2024-04-15 20:47:16 -0400, Tom Lane wrote:
>> Ah, thanks.  I guess this depends on getopt_long reordering arguments
>> (since the "-o outfile" bit will come later).  That is safe enough
>> in HEAD since 411b72034, but it might fail on weird platforms in v16.
>> How much do we care about that?  (We can avoid that hazard in the
>> makefile build easily enough.)

> As moving the arguments around would just be the following, I see no reason to
> just do so.

Fair enough.  I'm inclined to include that change only in v16, though.

			regards, tom lane

Commits

  1. Fix assorted bugs in ecpg's macro mechanism.