Horton

Re: Autogenerate some wait events code and documentation

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

View thread View on postgr.es
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-05-15T16:45:23Z
Lists: pgsql-hackers

Attachments

Hi,

On 5/6/23 4:37 AM, Michael Paquier wrote:
> On Sat, May 06, 2023 at 11:23:17AM +0900, Michael Paquier wrote:
>>> I'll look at v7 when the v17 branch opens and propose the separate patch
>>> mentioned above at that time too.
>>
>> Thanks, again.
> 
> By the way, while browsing through the patch, I have noticed two
> things:
> - The ordering of the items for Lock and LWLock is incorrect.

Oh right, fixed in V8 attached (moved the sort on the third column
instead of the second which has always the same content "WAIT_EVENT_DOCONLY"
for Lock and LWLock).

> - We are missing some of the LWLock entries, like CommitTsBuffer,
> XactBuffer or WALInsert, as of all the entries in
> BuiltinTrancheNames.
> 

Yeah, my bad. Fixed in V8 attached.

> My apologies for not noticing that earlier.  This exists in v6 as much
> as v7.

No problem at all and thanks for the call out!

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Commits

  1. Add "ABI_compatibility" regions to wait_event_names.txt

  2. Remove column for wait event names in wait_event_names.txt

  3. Use more consistent names for wait event objects and types

  4. Add information about line contents on parsing failure of wait_event_names.txt

  5. Remove double quotes from the second column of wait_event_names.txt

  6. Generate automatically code and documentation related to wait events

  7. Refactor some code related to wait events "BufferPin" and "Extension"

  8. doc: Fix ordering of entries in wait event table for I/O type