Horton

Re: Fixing AC_CHECK_DECLS to do the right thing with clang

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org, Noah Misch <noah@leadboat.com>
Date: 2018-11-18T22:02:48Z
Lists: pgsql-hackers 
Andres Freund <andres@anarazel.de> writes:
> Seems like a good plan. The problem doesn't reproduce for me on debian
> (using any version of clang), so all I can report is that at patched
> build still works as it should.

Interesting.  It's hardly surprising that the problem would occur only
on some platforms, since if <string.h> declares the function then the
problem isn't visible.  But I'm surprised that some Debian boxes would
show it and some not.  Still, a closer look at the buildfarm shows both
clang-on-Debian members with the warning (eg gull) and clang-on-Debian
members without (eg yours).

			regards, tom lane

Commits

  1. Fix configure's AC_CHECK_DECLS tests to work correctly with clang.