Horton

Re: pgsql: Default to hidden visibility for extension libraries where possi

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Pavel Stehule <pavel.stehule@gmail.com>, Andres Freund <andres@anarazel.de>, pgsql-committers@lists.postgresql.org
Date: 2022-07-19T13:45:52Z
Lists: pgsql-hackers 
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2022-Jul-19, Pavel Stehule wrote:
>> Unfortunately, this commit definitely breaks plpgsql_check. Can the
>> following routines be visible?

> Do you just need to send a patch to add an exports.txt file to
> src/pl/plpgsql/src/ for these functions?

The precedent of plpython says that PGDLLEXPORT markers are sufficient.
But yeah, we need a list of exactly which functions need to be
re-exposed.  I imagine pldebugger has its own needs.

			regards, tom lane

Commits

  1. Add PGDLLEXPORTS to some plpgsql function declarations

  2. Default to hidden visibility for extension libraries where possible

  3. Expose a few more PL/pgSQL functions to debugger plugins.