Re: pgsql: Improve internationalization of messages involving type names

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-committers@postgresql.org
Date: 2016-03-28T18:06:07Z
Lists: pgsql-hackers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Also, change them all to use the same quoting convention, namely that
> the function name is not to be quoted but the type name is.  (I'm not
> quite sure why this is so, but it's the clear majority.)

Actually, I think the general convention is to NOT quote type names
in error messages.  Certainly that's so when using format_type_be()
to produce a name for a not-known-at-compile-time type.  I would
argue that these messages should be written to look the same as if
format_type_be() had been used, and that would mean leaving off
the quotes.

			regards, tom lane


Commits

  1. Make messages mentioning type names more uniform

  2. Improve internationalization of messages involving type names

  3. psql tab-complete for CREATE/DROP ACCESS METHOD