Re: Question about make coverage-html
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Peter Smith <smithpb2250@gmail.com>,
PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-10-27T14:19:34Z
Lists: pgsql-hackers
Heikki Linnakangas <hlinnaka@iki.fi> writes:
> On 27/10/2020 10:09, Peter Smith wrote:
>> The documentation [1] also says "The make commands also work in
>> subdirectories." so I tried running them all in that folder.
>> However, when I run "make coverage-html" in that subdirectory
>> src/test/subscription it does not work:
> Creating a coverage report is a two-step process. First, you run the
> test you're interested in, with "make check" or similar. Then you create
> a report for the source files you're interested in, with "make
> coverage-html". You can run these commands in different subdirectories.
> In this case, you want to do "cd src/test/subscription; make check", to
> run those TAP tests, and then run "make coverage-html" from the top
> folder. Or if you wanted to create coverage report that covers only
> replication-related source code, for example, you could run it in the
> src/backend/replication directory ("cd src/backend/replication; make
> coverage-html").
I agree with the OP that the documentation is a bit vague here.
I think (maybe I'm wrong) that it's clear enough that you can run
whichever test case(s) you want, but this behavior of generating a
partial coverage report is less clear. Maybe instead of
The "make" commands also work in subdirectories.
we could say
You can run the "make coverage-html" command in a subdirectory
if you want a coverage report for only a portion of the code tree.
regards, tom lane
Commits
-
Doc: improve explanation of how to use our code coverage infrastructure.
- 8d132b2850d4 14.0 landed