Re: add a MAC check for TRUNCATE
Joe Conway <mail@joeconway.com>
From: Joe Conway <mail@joeconway.com>
To: Yuli Khodorkovskiy <yuli.khodorkovskiy@crunchydata.com>,
Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Tom Lane <tgl@sss.pgh.pa.us>,
Stephen Frost <sfrost@snowman.net>, Kohei KaiGai <kaigai@heterodb.com>,
pgsql-hackers@lists.postgresql.org,
Joshua Brindle <joshua.brindle@crunchydata.com>,
Mike P <mike.palmiotto@crunchydata.com>
Date: 2019-11-20T21:19:32Z
Lists: pgsql-hackers
Attachments
- Truncate-Hook-jc00.patch (text/x-patch) patch
- Truncate-Sepgsql-v3-jc01.patch (text/x-patch) patch v3
On 11/20/19 2:30 PM, Joe Conway wrote:
> On 11/8/19 9:16 AM, Joe Conway wrote:
>> On 11/8/19 9:02 AM, Yuli Khodorkovskiy wrote:
>>> On Thu, Nov 7, 2019 at 7:46 PM Michael Paquier <michael@paquier.xyz> wrote:
>>>>
>>>> On Mon, Sep 30, 2019 at 11:38:05AM -0300, Alvaro Herrera wrote:
>>>> > On 2019-Sep-30, Joe Conway wrote:
>>>> >
>>>> > > I am not sure I will get to this today. I assume it is ok for me to move
>>>> > > it forward e.g. next weekend, or is that not in line with commitfest rules?
>>>> >
>>>> > You can commit whatever patch whenever you feel like it. I will
>>>> > probably move this patch to the next commitfest before that, but you can
>>>> > mark it committed there as soon as you commit it.
>>>>
>>>> One month later, nothing has happened here. Joe, are you planning to
>>>> look at this patch?
>>>>
>>>> The last patch I found does not apply properly, so please provide a
>>>> rebase. I am switching the patch as waiting on author.
>>>
>>> Michael,
>>>
>>> I was able to apply the latest patches in the thread (9/25/19) on top
>>> of master. I have attached them for convenience.
>>
>> Yes, I will look when I am able. Hopefully this weekend, almost
>> certainly before the end of this commitfest.
>
> I tested this successfully on Rhinoceros, both with and without
> "db_table: { truncate }" loaded in the policy. Updated patches attached
> here with some editorialization. If there are no objections I will
> commit/push both in about a day or two.
...and I managed to drop the new files from the sepgsql patch. Complete
version attached.
Joe
--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development
Commits
-
Update sepgsql to add mandatory access control for TRUNCATE
- 4f66c93f6143 13.0 landed
-
Add object TRUNCATE hook
- f7a2002e82cf 13.0 landed
-
postgres_fdw: Fix error message for PREPARE TRANSACTION.
- 879c11761571 13.0 cited