Clean up MinGW def file generation
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: pgsql-hackers@postgresql.org
Date: 2019-10-15T07:00:23Z
Lists: pgsql-hackers
Attachments
- 0001-Clean-up-MinGW-def-file-generation.patch (text/plain) patch 0001
I was mystified by this comment in Makefile.shlib: # We need several not-quite-identical variants of .DEF files to build # DLLs for Windows. These are made from the single source file # exports.txt. Since we can't assume that Windows boxes will have # sed, the .DEF files are always built and included in distribution # tarballs. ifneq (,$(SHLIB_EXPORTS)) distprep: lib$(NAME)dll.def lib$(NAME)ddll.def ... This doesn't make much sense (anymore?) since MinGW surely has sed and MSVC doesn't use this (and has Perl). I think this is a leftover from various ancient client-only ad-hoc Windows build provisions (those win32.mak files we used to have around). Also, the ddll.def (debug build) isn't used by anything anymore AFAICT. I think we can clean this up and just have the regular ddl.def built normally at build time if required. Does anyone know more about this? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Remove libpq-dist.rc
- 508e84d79910 13.0 landed
-
Clean up MinGW def file generation
- ea9e06ac66d3 13.0 landed
-
Refactor the code that creates the shared library export files to appear
- a1d5d8574751 8.4.0 cited
-
Make a separate win32 debug DLL along with the non-debug version:
- 53cd7cd8a916 8.0.0 cited