Horton
Menu

Re: [PATCH] postmaster: fix stale PM_STARTUP comment

Heikki Linnakangas <hlinnaka@iki.fi>

View thread
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Ayush Tiwari <ayushtiwari.slg01@gmail.com>, pgsql-hackers@postgresql.org
Date: 2026-04-15T16:51:35Z
Lists: pgsql-hackers 
On 15/04/2026 16:57, Ayush Tiwari wrote:
> Hi,
> 
> The comment above the PM_STARTUP startup-process-failure case still says
> that there are no other processes running yet, so the postmaster can just
> exit.
> 
> That no longer matches the current startup flow: PM_STARTUP may already
> have auxiliary processes running by that point. The attached patch updates
> that comment to describe the current behavior.

Hmm, shouldn't the postmaster kill and wait for the auxiliary processes 
to exit first in that case? ISTM we need code changes here, not just 
comments.

- Heikki

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix orphaned processes when startup process fails during PM_STARTUP