Horton

Re: [BUGFIX] Fix crash due to sizeof bug in RegisterExtensionExplainOption

Andreas Karlsson <andreas@proxel.se>

View thread View on postgr.es
From: Andreas Karlsson <andreas@proxel.se>
To: Michael Paquier <michael@paquier.xyz>
Cc: Joel Jacobson <joel@compiler.org>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2026-03-03T04:14:55Z
Lists: pgsql-hackers 
On 3/3/26 5:13 AM, Michael Paquier wrote:
> On Tue, Mar 03, 2026 at 04:39:43AM +0100, Andreas Karlsson wrote:
>> Shouldn't the patch have used repalloc_array()? If the code had done so in
>> the first place the bug would never have happened.
> 
> I was considering that first.  However, after looked at the
> MemoryContextAlloc() and the inconsistency that repalloc_array() was
> bringing, I have turned the thought away.

Ah, makes sense but then the question is if we should make 
MemoryContextAlloc() more consistent with palloc() but that is a bigger 
question than just this small bugfix.

Andreas

Commits

  1. Fix memory allocation size in RegisterExtensionExplainOption()