Re: Patch to address creation of PgStat* contexts with null parent context

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, reid.thompson@crunchydata.com, pgsql-hackers@lists.postgresql.org
Date: 2022-09-19T08:57:18Z
Lists: pgsql-hackers
Hi,

On 9/17/22 6:10 PM, Andres Freund wrote:
> Hi,
> 
> On 2022-09-07 11:11:11 +0200, Drouvot, Bertrand wrote:
>> On 9/6/22 7:53 AM, Kyotaro Horiguchi wrote:
>>> At Mon, 5 Sep 2022 14:46:55 +0200, "Drouvot, Bertrand"<bdrouvot@amazon.com>  wrote in
>>>> Looks like that both approaches have their pros and cons. I'm tempted
>>>> to vote +1 on "just changing" the parent context to TopMemoryContext
>>>> and not changing the allocations locations.
>>> Yeah. It is safe more than anything and we don't have a problem there.
>>>
>>> So, I'm fine with just replacing the parent context at the three places.
>>
>> Attached a patch proposal to do so.
> 
> Pushed. Thanks for the report and the fix!

Thanks! I just marked the corresponding CF entry as Committed.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com



Commits

  1. pgstat: Create memory contexts below TopMemoryContext