Horton

Re: Make all Perl warnings fatal

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-12-29T19:27:31Z
Lists: pgsql-hackers 
On 22.12.23 22:33, Peter Eisentraut wrote:
> On 12.09.23 07:42, Peter Eisentraut wrote:
>> On 10.08.23 07:58, Peter Eisentraut wrote:
>>> There are also a couple of issues in the MSVC legacy build system 
>>> that would need to be tightened up in order to survive with fatal 
>>> Perl warnings.  Obviously, there is a question whether it's worth 
>>> spending any time on that anymore.
>>
>> It looks like there are no principled objections to the overall idea 
>> here, but given this dependency on the MSVC build system removal, I'm 
>> going to set this patch to Returned with feedback for now.
> 
> Now that that is done, here is an updated patch for this.
> 
> I found one more bug in the Perl code because of this, a fix for which 
> is included here.
> 
> With this fix, this passes all the CI tests on all platforms.

committed

Commits

  1. Add missing FATAL => 'all' to a use warnings in Perl

  2. Make all Perl warnings fatal in 043_wal_replay_wait.pl

  3. Add tap test for pg_signal_autovacuum role

  4. Implement pg_wal_replay_wait() stored procedure

  5. Fix an issue in PostgreSQL::Test::Cluster:psql()

  6. Make all Perl warnings fatal

  7. Fix a warning in Perl test code

  8. Avoid use of Perl getprotobyname