Re: Align tests for stored and virtual generated columns

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>
To: Yugo Nagata <nagata@sraoss.co.jp>, Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2026-03-27T15:00:42Z
Lists: pgsql-hackers
On 08.08.25 04:51, Yugo Nagata wrote:
> I noticed that the tests for virtual and stored generated columns
> contain the following comment;
> 
>   -- keep these tests aligned with generated_stored.sql (or generated_virtual.sql)
> 
> However, it seems that some additional tests for virtual generated columns
> disrupted that alignment, as they were not added to generated_stored.sql.
> 
> I've attached a patch to restore the alignment.
> 
> In addition, I moved the test confirming that user-defined types are not allowed
> in virtual generated columns to the generated_virtual.sql-specific section,
> since this test is not necessary for stored generated columns.

Committed, thanks.




Commits

  1. Align tests for stored and virtual generated columns