Horton

Thread

Commits

  1. Enable hash partitioning of text arrays

  2. Collations with nondeterministic comparison

  1. hash_array_extended() needs to pass down collation

    Peter Eisentraut <peter.eisentraut@enterprisedb.com> — 2020-11-02T07:40:11Z

    I noticed that hash_array_extended() does not pass down the collation to 
the element's collation function, unlike hash_array().  As a 
consequence, hash partitioning using text arrays as partition key fails.

The attached patch fixes this.  I propose to backpatch this.

  2. Re: hash_array_extended() needs to pass down collation

    Heikki Linnakangas <hlinnaka@iki.fi> — 2020-11-02T11:52:48Z

    On 02/11/2020 09:40, Peter Eisentraut wrote:
> I noticed that hash_array_extended() does not pass down the collation to
> the element's collation function, unlike hash_array().  As a
> consequence, hash partitioning using text arrays as partition key fails.
> 
> The attached patch fixes this.  I propose to backpatch this.

+1. Straightforward oversight in commit 5e1963fb764e.

- Heikki

  3. Re: hash_array_extended() needs to pass down collation

    Tom Lane <tgl@sss.pgh.pa.us> — 2020-11-02T15:01:53Z

    Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> I noticed that hash_array_extended() does not pass down the collation to 
> the element's collation function, unlike hash_array().  As a 
> consequence, hash partitioning using text arrays as partition key fails.

> The attached patch fixes this.  I propose to backpatch this.

LGTM

			regards, tom lane

  4. Re: hash_array_extended() needs to pass down collation

    Michael Paquier <michael@paquier.xyz> — 2020-11-03T10:48:54Z

    On Mon, Nov 02, 2020 at 10:01:53AM -0500, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
>> I noticed that hash_array_extended() does not pass down the collation to 
>> the element's collation function, unlike hash_array().  As a 
>> consequence, hash partitioning using text arrays as partition key fails.
> 
>> The attached patch fixes this.  I propose to backpatch this.
> 
> LGTM

+1.
--
Michael

  5. Re: hash_array_extended() needs to pass down collation

    Peter Eisentraut <peter.eisentraut@enterprisedb.com> — 2020-11-04T11:51:40Z

    On 2020-11-03 11:48, Michael Paquier wrote:
> On Mon, Nov 02, 2020 at 10:01:53AM -0500, Tom Lane wrote:
>> Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
>>> I noticed that hash_array_extended() does not pass down the collation to
>>> the element's collation function, unlike hash_array().  As a
>>> consequence, hash partitioning using text arrays as partition key fails.
>>
>>> The attached patch fixes this.  I propose to backpatch this.
>>
>> LGTM
> 
> +1.

committed