Re: get rid of Pointer type, mostly

David Geier <geidav.pg@gmail.com>

From: David Geier <geidav.pg@gmail.com>

To: Peter Eisentraut <peter@eisentraut.org>, Chao Li <li.evan.chao@gmail.com>

Cc: Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2025-12-08T11:27:19Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Remove no longer needed casts from Pointer
- e158fd4d68f4 19 (unreleased) landed
Remove no longer needed casts to Pointer
- c6be3daa054a 19 (unreleased) landed
Change Pointer to void *
- 1b2bb5077e9e 19 (unreleased) landed
Don't rely on pointer arithmetic with Pointer type
- 756a43689324 19 (unreleased) landed
Use more appropriate DatumGet* function
- 8c6bbd674ed8 19 (unreleased) landed
Remove useless casts to Pointer
- 623801b3bdb4 19 (unreleased) landed

On 08.12.2025 12:14, Peter Eisentraut wrote:
> I was planning to proceed with Dagfinn's patch set.  Here is what is
> currently remaining of the patch series.  I haven't fully processed
> everyone's comments in this thread, so they might not be reflected in
> these patches.
Dagfinn's patch set turns Pointer into void *. I thought we had agreed
to use something like GinExtraPointer in the GIN code (see my patch set).

Either way is fine by me. It just seemed like the majority of commenters
where in favor of keeping some type in the GIN code for readability.
> 
> There is some interference from the changes from palloc to
> palloc_object/_array/etc., and I was also trying to figure out what to
> do with the commented out code, hence the delay.
Understood.

--
David Geier