Re: Fixing cache pollution in the Kerberos test suite
Jacob Champion <pchampion@vmware.com>
From: Jacob Champion <pchampion@vmware.com>
To: "tgl@sss.pgh.pa.us" <tgl@sss.pgh.pa.us>, "sfrost@snowman.net" <sfrost@snowman.net>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2021-01-25T19:00:41Z
Lists: pgsql-hackers
On Mon, 2021-01-25 at 13:49 -0500, Tom Lane wrote: > Yeah, changing global state is just awful. However, I don't > actually see any change here (RHEL8): Interesting. I'm running Ubuntu 20.04: $ klist klist: No credentials cache found (filename: /tmp/krb5cc_1000) $ make check ... $ klist Ticket cache: FILE:/tmp/krb5cc_1000 Default principal: test1@EXAMPLE.COM Valid starting Expires Service principal ... krbtgt/EXAMPLE.COM@EXAMPLE.COM ... postgres/auth-test-localhost.postgresql.example.com@ ... postgres/auth-test-localhost.postgresql.example.com@EXAMPLE.COM I wonder if your use of a KCM cache type rather than FILE makes the difference? > Also, why are you only setting the ENV variable within narrow parts > of the test script? I'd be inclined to enforce it throughout. I considered it and decided I didn't want to pollute the server's environment with it, since the server shouldn't need the client cache. But I think it'd be fine (and match the current situation) if it were set once for the whole script, if you prefer. --Jacob
Commits
-
Don't clobber the calling user's credentials cache in Kerberos test.
- b8894a3661d4 11.11 landed
- 881933f19422 14.0 landed
- 820aa9ef4c35 12.6 landed
- 366d302d14f7 13.2 landed