Horton

Thread

Commits

  1. Remove obsolete HAVE_BUGGY_SOLARIS_STRTOD

  2. Remove obsolete cygwin.h hack

  1. remove some ancient port hacks

    Peter Eisentraut <peter.eisentraut@2ndquadrant.com> — 2020-08-12T07:12:07Z

    There are two ancient hacks in the cygwin and solaris ports that appear 
to have been solved more than 10 years ago, so I think we can remove 
them.  See attached patches.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

  2. Re: remove some ancient port hacks

    Marco Atzeri <marco.atzeri@gmail.com> — 2020-08-12T08:18:00Z

    On 12.08.2020 09:12, Peter Eisentraut wrote:
> There are two ancient hacks in the cygwin and solaris ports that appear 
> to have been solved more than 10 years ago, so I think we can remove 
> them.  See attached patches.
> 

Hi Peter,
This is really archeology

   Check for b20.1

as it was released in 1998.
No problem at all to remove it

Regards Marco
Cygwin Package Maintainer

  3. Re: remove some ancient port hacks

    Noah Misch <noah@leadboat.com> — 2020-08-13T03:22:52Z

    On Wed, Aug 12, 2020 at 09:12:07AM +0200, Peter Eisentraut wrote:
> There are two ancient hacks in the cygwin and solaris ports that appear to
> have been solved more than 10 years ago, so I think we can remove them.  See
> attached patches.

+1 for removing these.  >10y age is not sufficient justification by itself; if
systems that shipped with the defect were not yet EOL, that would tend to
justify waiting longer.  For these particular hacks, though, affected systems
are both old and EOL.

  4. Re: remove some ancient port hacks

    Peter Eisentraut <peter.eisentraut@2ndquadrant.com> — 2020-08-15T09:39:40Z

    On 2020-08-12 10:18, Marco Atzeri wrote:
> On 12.08.2020 09:12, Peter Eisentraut wrote:
>> There are two ancient hacks in the cygwin and solaris ports that appear
>> to have been solved more than 10 years ago, so I think we can remove
>> them.  See attached patches.
>>
> 
> Hi Peter,
> This is really archeology
> 
>     Check for b20.1
> 
> as it was released in 1998.
> No problem at all to remove it

Committed.  Thanks for the feedback.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

  5. Re: remove some ancient port hacks

    Peter Eisentraut <peter.eisentraut@2ndquadrant.com> — 2020-08-15T09:41:53Z

    On 2020-08-13 05:22, Noah Misch wrote:
> On Wed, Aug 12, 2020 at 09:12:07AM +0200, Peter Eisentraut wrote:
>> There are two ancient hacks in the cygwin and solaris ports that appear to
>> have been solved more than 10 years ago, so I think we can remove them.  See
>> attached patches.
> 
> +1 for removing these.  >10y age is not sufficient justification by itself; if
> systems that shipped with the defect were not yet EOL, that would tend to
> justify waiting longer.  For these particular hacks, though, affected systems
> are both old and EOL.

done

In this case, the bug was fixed in the stable release track of this OS, 
so the only way to still be affected would be if you had never installed 
any OS patches in 10 years, which is clearly unreasonable.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services