Horton

Re: Collation & ctype method table, and extension hooks

Andreas Karlsson <andreas@proxel.se>

View thread View on postgr.es
From: Andreas Karlsson <andreas@proxel.se>
To: Jeff Davis <pgsql@j-davis.com>, pgsql-hackers@postgresql.org
Date: 2024-12-20T05:48:54Z
Lists: pgsql-hackers

Attachments


On 12/5/24 1:21 AM, Jeff Davis wrote:
>> = v9-0003-Move-code-for-collation-version-into-provider-spe.patch
>>
>> Moves some code from pg_collate.c into provider specific files.
> 
> I agree with the general idea, but it seems we are accumulating a lot
> of provider-specific functions. Should we define a provider struct with
> its own methods?
> 
> That would be a good step toward making the provider catalog-driven.
> Even if we don't support CREATE LOCALE PROVIDER, having space in the
> catalog would be a good place to track the provider version.

Yeah, that was my idea too but I just have not gotten around to it yet.

>> = v9-0004-Move-ICU-database-encoding-check-into-validation-.patch
> 
> This seems to be causing a test failure in 020_createdb.pl.

Thanks, I have attached a fixup commit for this.

Andreas

Commits

  1. Remove provider field from pg_locale_t.

  2. Control ctype behavior internally with a method table.

  3. Control collation behavior with a method table.

  4. Move code for collation version into provider-specific files.

  5. Refactor string case conversion into provider-specific files.

  6. Move check for ucol_strcollUTF8 to pg_locale_icu.c

  7. Perform provider-specific initialization in new functions.

  8. Refactor the code to create a pg_locale_t into new function.