Horton

Re: Improve a few appendStringInfo calls new to v18

Heikki Linnakangas <hlinnaka@iki.fi>

View thread View on postgr.es
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: David Rowley <dgrowleyml@gmail.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2025-04-10T08:24:36Z
Lists: pgsql-hackers 
On 10/04/2025 06:51, David Rowley wrote:
> Looks like v18 has grown a few appendStringInfo misusages, e.g. using
> appendStringInfo() when no formatting is needed or just using format
> "%s" instead of using appendStringInfoString().
> 
> I've attached a couple of patches. The 0001 is just my method for
> finding these, not for commit. 

Clever!

> 0002 contains the fixes to commit.
> 
> Any objections to doing this soonish? Or in a few weeks?

Sure, let's do it. Why would we wait?

-- 
Heikki Linnakangas
Neon (https://neon.tech)

Commits

  1. Improve various new-to-v18 appendStringInfo calls

  2. Fixup various StringInfo function usages