Re: Improper use about DatumGetInt32

Anastasia Lubennikova <a.lubennikova@postgrespro.ru>

From: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>

To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Ashutosh Bapat <ashutosh.bapat@2ndquadrant.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>

Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>, "Hou, Zhijie" <houzj.fnst@cn.fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2020-11-25T14:43:03Z

Lists: pgsql-hackers

Attachments

0001-Handle-negative-number-of-tuples_v1.patch (text/x-patch) patch v1-0001

On 02.11.2020 18:59, Peter Eisentraut wrote:
> I have committed 0003.
>
> For 0001, normal_rand(), I think you should reject negative arguments 
> with an error.

I've updated 0001. The change is trivial, see attached.

>
> For 0002, I think you should change the block number arguments to 
> int8, same as other contrib modules do.
>
Agree. It will need a bit more work, though. Probably a new version of 
pageinspect contrib, as the public API will change.
Ashutosh, are you going to continue working on it?

-- 
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Commits

pageinspect: Change block number arguments to bigint
- f18aa1b20393 14.0 landed
tablefunc: Reject negative number of tuples passed to normal_rand()
- f73999262ed6 14.0 landed
Use PG_GETARG_TRANSACTIONID where appropriate
- dd26a0ad760b 14.0 landed