Horton

Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line

Alexey Kondratov <a.kondratov@postgrespro.ru>

View thread
From: Alexey Kondratov <a.kondratov@postgrespro.ru>
To: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>, Dmitry Dolgov <9erthalion6@gmail.com>, Michael Paquier <michael@paquier.xyz>, Alvaro Herrera <alvherre@2ndquadrant.com>, vladimirlesk@yandex-team.ru, dsarafan@yandex-team.ru
Date: 2019-02-11T09:56:45Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Move frontend-side archive APIs from src/common/ to src/fe_utils/

  2. Add -c/--restore-target-wal to pg_rewind

  3. Move routine definitions of xlogarchive.c to a new header file

  4. Move routine building restore_command to src/common/

  5. Integrate recovery.conf into postgresql.conf

Hi!

On 09.02.2019 14:31, Andrey Borodin wrote:
> Here's a typo in postgreslq.conf
> +			fprintf(stderr, _("%s: option -r/--use-postgresql-conf is specified, but postgreslq.conf is absent in the target directory\n"),

Fixed, thanks. I do not attach new version of the patch for just one 
typo, maybe there will be some more remarks from others.

> Besides this, I think you can switch patch to "Ready for committer".
>
> check-world is passing on macbook, docs are here, feature is implemented and tested.

OK, cfbot [1] does not complain about anything on Linux and Windows as 
well, so I am setting it to "Ready for committer" for the next commitfest.


[1] http://cfbot.cputube.org/alexey-kondratov.html


Regards

-- 
Alexey Kondratov

Postgres Professional https://www.postgrespro.com
Russian Postgres Company