Horton

Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files

Daniel Gustafsson <daniel@yesql.se>

View thread
From: Daniel Gustafsson <daniel@yesql.se>
To: Tobias Bussmann <t.bussmann@gmx.net>
Cc: Michael Paquier <michael@paquier.xyz>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Mark Guertin <markguertin@gmail.com>, pgsql-bugs@lists.postgresql.org
Date: 2023-05-02T10:34:59Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Skip .DS_Store files in server side utils

> On 1 May 2023, at 23:23, Tobias Bussmann <t.bussmann@gmx.net> wrote:

> The safe solution for the back branches would be to add '{".DS_Store", false}' to the exclude_list_item arrays in backend/backup/basebackup.c, bin/pg_checksums/pg_checksums.c and bin/pg_rewind/filemap.c, but I can't judge whether this would justify using a different codepath for the older versions or not.

If we deem this to be a bugfix then we should backpatch the solution from HEAD
imho.  So far there are mainly voices for considering it a bugfix, but given
where we are in the cycle I the RMT has the final say on that.

--
Daniel Gustafsson