Horton

Re: [PoC] Federated Authn/z with OAUTHBEARER

Daniel Gustafsson <daniel@yesql.se>

View thread
From: Daniel Gustafsson <daniel@yesql.se>
To: Jacob Champion <jacob.champion@enterprisedb.com>
Cc: Peter Eisentraut <peter@eisentraut.org>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2024-10-18T11:38:29Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. meson: Fix install-quiet after clean

  2. oauth: Run Autoconf tests with correct compiler flags

  3. Link libpq with libdl if the platform needs that.

  4. Doc: correct spelling of meson switch.

  5. oauth: Correct SSL dependency for libpq-oauth.a

  6. oauth: Fix Autoconf build on macOS

  7. oauth: Move the builtin flow into a separate module

  8. Remove a stray "pgrminclude" annotation

  9. oauth: Simplify copy of PGoauthBearerRequest

  10. oauth: Improve validator docs on interruptibility

  11. oauth: Disallow synchronous DNS in libcurl

  12. oauth: Fix postcondition for set_timer on macOS

  13. oauth: Use IPv4-only issuer in oauth_validator tests

  14. Work around OAuth/EVFILT_TIMER quirk on NetBSD.

  15. oauth: Fix incorrect const markers in struct

  16. Add missing entry to oauth_validator test .gitignore

  17. cirrus: Temporarily fix libcurl link error

  18. Add support for OAUTHBEARER SASL mechanism

  19. libpq: Handle asynchronous actions during SASL

  20. require_auth: prepare for multiple SASL mechanisms

  21. Move PG_MAX_AUTH_TOKEN_LENGTH to libpq/auth.h

  22. Make SASL max message length configurable

  23. jsonapi: fully initialize dummy lexer

  24. common/jsonapi: support libpq as a client

  25. Remove fe_memutils from libpgcommon_shlib

  26. Revert ECPG's use of pnstrdup()

  27. Explicitly require password for SCRAM exchange

  28. Refactor SASL exchange to return tri-state status

Attachments

> On 16 Oct 2024, at 19:21, Jacob Champion <jacob.champion@enterprisedb.com> wrote:

> v31 folds in the remainder of the review patch (hooray!) and makes a
> change to the 401 handling. If the server doesn't tell the client why
> a token request failed, but we see that we got a 401 Unauthorized, the
> error message now suggests that the oauth_client_secret setting is
> unacceptable.

+1

The attached diff expands the documentation a little to chip away at the
non-trivial task of documenting this feature.  I will keep working on this part
as well reviewing the rest of the patchset.  A few more comments are added as
well but nothing groundbreaking.  I've attached your v31 vanilla as well to
keep the CFBot happy.

A few small comments on things in the attached review 0005 comment:

-    (errcode(ERRCODE_PROTOCOL_VIOLATION),
-     errmsg("client selected an invalid SASL authentication mechanism")));
+    errcode(ERRCODE_PROTOCOL_VIOLATION),
+    errmsg("client selected an invalid SASL authentication mechanism"));
Might be a nitpick but in new code I think we should use the new style of
ereport() calls without extra parens around the aux functions.

In validate() it seems to me we should clear out ret->authn_id on failure to
pair belts with suspenders. Fixed by calling explicit_bzero on it in the error
path.

parse_hba_line() didn't enforce mandatory parameters, and one could configure a
usermap and skipping of the usermap at the same time which seems nonsensical.

src/test/modules/oauth_validator didn't check for PG_TEST_EXTRA which is should
since it opens a server.  We should also not test capabilities with if-elsif
since they are really separate things.

A few smaller bits and pieces of cleanup is also included.

--
Daniel Gustafsson