Thread

Re: [PATCH] Add memory usage reporting to VACUUM VERBOSE

Chao Li <li.evan.chao@gmail.com> — 2025-12-24T09:06:50Z

> On Dec 23, 2025, at 21:20, Tatsuya Kawata <kawatatatsuya0913@gmail.com> wrote:
> 
> Hi Sawada-san and Chao-san,
> 
> Thank you both for your continued reviews and feedback on this patch.
> 
> > The patch mostly looks good to me. I've made some cosmetic changes to
> >   the comments  (as well as the commit message) and attached the updated
> >   patch. Please review it.
> Thank you. I have no objections.
> 
> 
> > My last nitpick on v9:
> > 
> >   ```
> >   +                       appendStringInfo(&buf,
> >   +                                                        ngettext("memory usage: %.2f MB in total, with dead-item storage reset %d time (limit was %.2f MB)\n",
> >   +                                                                         "memory usage: %.2f MB in total, with dead-item storage reset %d times (limit was %.2f MB)\n",
> >   ```
> > 
> >   Instead of “dead-item”, I would suggest “dead item” (without dash), because in the existing code use “dead item”, for example:
> > 
> >   ```
> I've addressed your feedback.
> 
> Attached is v10 with these changes incorporated.
> I really appreciate reviewing this patch throughout the iterations.
> 
> Regards,
> Tatsuya Kawata
> <v10-0001-Add-dead-items-memory-usage-to-VACUUM-VERBOSE-an.patch>

V10 looks good to me.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/