Horton
Menu

Re: Few untranslated error messages in OAuth

Daniel Gustafsson <daniel@yesql.se>

View thread
From: Daniel Gustafsson <daniel@yesql.se>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-13T12:49:27Z
Lists: pgsql-hackers 
> On 13 Nov 2025, at 13:32, Álvaro Herrera <alvherre@kurilemu.de> wrote:
> 
> On 2025-Nov-13, Daniel Gustafsson wrote:
> 
>> I was pondering that since auth error messages in backend libpq does this, but
>> since we don't use gettext_noop anywhere else in frontend libpq today it makes
>> sense to go with libpq_gettext and update the docs instead.
>> 
>> Unless you, who has more translation/nls insights than me, feel strongly about
>> gettext_noop I'll go ahead with the current patch.
> 
> gettext_noop() does something completely different from libpq_gettext(),
> and the more I think about this, the more I think doing libpq_gettext()
> is the wrong thing.  

If so, should that be extended to oauth_json_set_error as well? (and possibly others?)

> I can give it a shot if you want.

If you have time, that would be great.

--
Daniel Gustafsson

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. libpq: Align oauth_json_set_error() with other NLS patterns

  2. libpq-oauth: Don't translate internal errors

  3. libpq: Add missing OAuth translations