Horton

Re: Move SLRU_PAGES_PER_SEGMENT to pg_config_manual.h

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Maxim Orlov <orlovmg@gmail.com>, Daniil Davydov <3danissimo@gmail.com>
Date: 2025-11-10T11:41:01Z
Lists: pgsql-hackers 
> On 10 Nov 2025, at 12:29, Heikki Linnakangas <hlinnaka@iki.fi> wrote:

> There was a suggestion earlier to make SLRU_PAGES_PER_SEGMENT a configure option [2]. I don't want to go that far; pg_config_manual.h seems like the right level of configurability to me.

Agreed.  The thread referenced above never really answered why a configure time
option would be needed.

+	uint32		slru_pages_per_segment; /* size of each SLRU segment */

Should this be expanded ever so slightly?  A new reader of the code might
wonder about the relationship between "pages_per" and "size".

No objections (apart from the catversion =)) from reading the patch.

--
Daniel Gustafsson

Commits

  1. Add warning to pg_controldata on PG_CONTROL_VERSION mismatch

  2. Add pg_resetwal and pg_controldata support for new control file field

  3. Bump PG_CONTROL_VERSION for commit 3e0ae46d90

  4. Move SLRU_PAGES_PER_SEGMENT to pg_config_manual.h