Horton

Re: [PATCH] Add min/max aggregate functions to BYTEA

x4mmm@yandex-team.ru

View thread View on postgr.es
From: "Andrey M. Borodin" <x4mmm@yandex-team.ru>
To: Marat Bukharov <marat.buharov@gmail.com>
Cc: Aleksander Alekseev <aleksander@timescale.com>, pgsql-hackers@postgresql.org
Date: 2024-08-02T09:20:04Z
Lists: pgsql-hackers 

> On 24 Jul 2024, at 17:42, Marat Bukharov <marat.buharov@gmail.com> wrote:
> 
> V5 patch. I've added more tests with different bytea sizes

Hi Marat!

This looks like a nice feature to have.

I’ve took a look into the patch and have few suggestions:
0. Please write more descriptive commit message akin to [0]
1. Use oids from development range 8000-9999
2. Replace VARDATA_ANY\memcmp dance with a call to varstrfastcmp_c().

Thank you!


Best regards, Andrey Borodin.

[0] https://github.com/postgres/postgres/commit/a0f1fce80c03

Commits

  1. Add min and max aggregates for bytea type.