Re: be-gssapi-common.h should be located in src/include/libpq/
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>,
Stephen Frost <sfrost@snowman.net>,
Alvaro Herrera <alvherre@2ndquadrant.com>
Date: 2019-06-07T07:52:26Z
Lists: pgsql-hackers
Attachments
- libpq_reorg.diff (application/octet-stream) patch
> On 7 Jun 2019, at 06:34, Michael Paquier <michael@paquier.xyz> wrote: > Any objections to something like the attached? No objections to moving the file per the patch. While looking at libpq.h I noticed what seems to be a few nitpicks: the GSS function prototype isn’t using the common format of having a comment specifying the file it belongs to; ssl_loaded_verify_locations is defined as extern even though it’s only available under USE_SSL (which works fine since it’s only accessed under USE_SSL but seems kinda wrong); and FeBeWaitSet is not listed under the pqcomm.c prototypes like how the extern vars from be-secure.c are. All of these are in the attached. cheers ./daniel
Commits
-
Switch position of some declarations in libpq.h
- cf4263cc6c3a 12.0 landed
-
Move be-gssapi-common.h into src/include/libpq/
- 35b2d4bc0eb5 12.0 landed