Horton

RE: [bug fix] pg_rewind takes long time because it mistakenly copies data files

Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>

View thread View on postgr.es
From: "Tsunakawa, Takayuki" <tsunakawa.takay@jp.fujitsu.com>
To: 'Michael Paquier' <michael@paquier.xyz>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2018-02-28T06:58:08Z
Lists: pgsql-hackers

Attachments

From: Michael Paquier [mailto:michael@paquier.xyz]
> So I would propose to just do that later.  I have looked a second time at
> your patch, attached is the set of tests I have run:

Thanks so much, that has helped me a lot!

> I have one small comment though.  The comment block at the beginning of
> isRelDataFile() refers to "pg_tblspc/<tblspc oid>/PG_9.4_201403261/".
> Could you switch that to "pg_tblspc/<tblspc oid>/<tblspc version>"?
> That's not directly the fault of your patch, but as long as we are on it..

Done, thanks again for marking the CF entry.

Regards
Takayuki Tsunakawa

Commits

  1. Fix pg_rewind to handle relation data files in tablespaces properly.