Re: logical replication launcher crash on buildfarm

Petr Jelinek <petr.jelinek@2ndquadrant.com>

From: Petr Jelinek <petr.jelinek@2ndquadrant.com>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Andres Freund <andres@anarazel.de>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Petr Jelinek <petr@2ndquadrant.com>, Peter Eisentraut <peter_e@gmx.net>

Date: 2017-04-01T00:32:41Z

Lists: pgsql-hackers

Attachments

Use-library_name-function_name-for-loading-main-entr-96-v2.patch (application/x-patch) patch v2
Use-library_name-function_name-for-loading-main-entr-HEAD-v2.patch (application/x-patch) patch v2

On 31/03/17 15:42, Robert Haas wrote:
> On Tue, Mar 28, 2017 at 7:39 PM, Petr Jelinek
> <petr.jelinek@2ndquadrant.com> wrote:
>> Sigh, forgot git add for the docs, so one more try...
> 
> +    if (strncmp(worker->bgw_library_name, "postgres", 8) != 0)
> +        return NULL;
> 
> I think that's not right.  You don't want to match postgresshdkgjsdglkjs.
>

Right, changed to BGW_MAXLEN.

> Aside from that, these look good to me.
> 

Cool.

-- 
  Petr Jelinek                  http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services

Commits

Avoid passing function pointers across process boundaries.
- 9c225acf0b97 9.6.3 landed
- 32470825d36d 10.0 landed
Don't use bgw_main even to specify in-core bgworker entrypoints.
- 0ef26bb394ab 9.5.7 landed
- 9b6e8d8f86ac 9.6.3 landed
- 2113ac4cbb12 10.0 landed