Horton

Re: Avoid extra Sort nodes between WindowAggs when sorting can be reused

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, Alexander Kuzmenkov <a.kuzmenkov@postgrespro.ru>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2018-09-12T20:32:59Z
Lists: pgsql-hackers 
> On 12 Sep 2018, at 22:15, Andrew Gierth <andrew@tao11.riddles.org.uk> wrote:

> WindowClauseSortNode - I don't like this name, because it's not actually
> a Node of any kind. How about WindowSortData?

That’s a good point.  I probably would’ve named it WindowClauseSortData since
it acts on WindowClauses, but that might just be overly verbose.

> Any comments? (no need to post further patches unless there's some major
> change needed)

I have no objections to the comments made in this review, only the above
nitpick.

Thanks for picking this up!

cheers ./daniel

Commits

  1. Order active window clauses for greater reuse of Sort nodes.