Horton

Re: [PATCH] Improve geometric types

Tomas Vondra <tomas.vondra@2ndquadrant.com>

View thread View on postgr.es
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: emre@hasegeli.com, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>, Thomas Munro <thomas.munro@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2018-09-26T21:09:07Z
Lists: pgsql-hackers 

On 09/26/2018 10:58 PM, Tom Lane wrote:
> Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
>> Hmmm, interesting. It seems both failures happen in the chunk that
>> multiplies paths with points, i.e. essentially point_mul_point. So it
>> seems most platforms end up with
> 
>>     (0,0) * (-3,4) = (-0, 0)
> 
>> while gaur apparently thinks it's (0,0). And indeed, that's what the
>> attached trivial program does - I'd bet if you run it on gaur, it'll
>> print 0.000000, not -0.000000.
> 
> Nope, no cigar:
> 
> $ gcc -Wall -O2 test.c
> $ ./a.out
> -0.000000
> 
> (I tried a couple other -O levels to see if that affected anything,
> but it didn't.)
> 

Interesting ...

> I'll try to isolate the problem more closely, but it will take awhile.
> That machine is slow :-(
> 

OK, thanks.


regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Improve test coverage of geometric types

  2. Fix problems in handling the line data type

  3. Use the built-in float datatypes to implement geometric types

  4. Remove remaining GEODEBUG references from geo_ops.c

  5. Provide separate header file for built-in float types

  6. Refactor geometric functions and operators

  7. Fix crash in close_ps() for NaN input coordinates.

  8. Fix GiST index build for NaN values in geometric types.

  9. Enable building with Visual Studion 2013.

  10. Suppress -0 in the C field of lines computed by line_construct_pts().