Horton

Re: [POC] Fast COPY FROM command for the table with foreign partitions

Andrei Lepikhov <a.lepikhov@postgrespro.ru>

View thread View on postgr.es
From: Andrey Lepikhov <a.lepikhov@postgrespro.ru>
To: "tsunakawa.takay@fujitsu.com" <tsunakawa.takay@fujitsu.com>, 'Etsuro Fujita' <etsuro.fujita@gmail.com>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>, Amit Langote <amitlangote09@gmail.com>, Alexey Kondratov <a.kondratov@postgrespro.ru>, Michael Paquier <michael@paquier.xyz>, Ashutosh Bapat <ashutosh.bapat@2ndquadrant.com>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, PostgreSQL-Dev <pgsql-hackers@postgresql.org>
Date: 2020-11-24T06:04:27Z
Lists: pgsql-hackers 

On 11/24/20 9:27 AM, tsunakawa.takay@fujitsu.com wrote:
> Andrey-san, Fujita-san,
> 
> From: Etsuro Fujita <etsuro.fujita@gmail.com>
>> On Mon, Nov 23, 2020 at 5:39 PM Andrey Lepikhov
>> <a.lepikhov@postgrespro.ru> wrote:
>>> On 11/23/20 7:49 AM, tsunakawa.takay@fujitsu.com wrote:
>>>> Could I or my colleague continue this patch in a few days?  It looks it's
>> stalled over one month.
>>>
>>> I don't found any problems with this patch that needed to be corrected.
>>> It is wait for actions from committers side, i think.
>>
>> I'm planning to review this patch.  I think it would be better for
>> another pair of eyes to take a look at it, though.
> 
> 
> There are the following two issues left untouched.
> 
> https://www.postgresql.org/message-id/TYAPR01MB2990DC396B338C98F27C8ED3FE1F0%40TYAPR01MB2990.jpnprd01.prod.outlook.com

I disagree with your opinion about changing the interface of the 
ExecRelationAllowsMultiInsert routine. If you insist on the need for 
this change, we need another opinion.

-- 
regards,
Andrey Lepikhov
Postgres Professional

Commits

  1. Allow batch insertion during COPY into a foreign table.

  2. postgres_fdw: Disable batch insertion when there are WCO constraints.

  3. Enforce foreign key correctly during cross-partition updates

  4. Fix permission checks on constraint violation errors on partitions.

  5. Fix compilation of uuid-ossp