Re: should check collations when creating partitioned index
Jeff Davis <pgsql@j-davis.com>
From: Jeff Davis <pgsql@j-davis.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter@eisentraut.org>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-11-17T21:08:09Z
Lists: pgsql-hackers
On Fri, 2023-11-17 at 15:18 -0500, Tom Lane wrote: > You keep harping on this idea that we are only concerned with > equality, > but I think you are wrong. We expect a btree index to provide > ordering > not only equality, and this example definitely is a btree index. > > Possibly, with a great deal more specificity added to the check, we > could distinguish the cases where ordering can't matter and allow > collation variance then. I do not see the value of that, especially > not when measured against the risk of introducing subtle bugs. Fair point. As background, I don't see a complete solution to our collation problems and on the horizon. You've probably noticed that I'm looking for various ways to mitigate the problem, and this thread was about reducing the number of situations in which we rely on collation. I'll focus on other potential improvements/mitigations and see if I can make progress somewhere else. Regards, Jeff Davis
Commits
-
Check collation when creating partitioned index
- 5d40b3c4f6ca 12.18 landed
- 3c49fa2aff2c 13.14 landed
- e846fc491923 14.11 landed
- 15d485921b1c 15.6 landed
- 267f33f68417 16.2 landed
- a11c9c42ea31 17.0 landed