Re: Add Postgres module info
Andrei Lepikhov <lepihov@gmail.com>
From: Andrei Lepikhov <lepihov@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2024-12-12T08:40:50Z
Lists: pgsql-hackers
Attachments
- v1-0001-Introduce-PG_MODULE_MAGIC_EXT-macro.patch (text/x-patch) patch v1-0001
On 12/12/24 08:36, Tom Lane wrote: > Andrei Lepikhov <lepihov@gmail.com> writes: >> It makes sense. But I want to clarify that I avoided changing >> PG_MODULE_MAGIC because the newly introduced structure has a totally >> different purpose and usage logic: the struct is designed to check >> compatibility, but module info isn't connected to the core version at >> all: a single version of the code may be built for multiple PG versions. >> At the same time, various versions of the same library may be usable >> with the same core. > > Surely. But I don't see a need for two separately-looked-up > physical structures. Seems to me it's sufficient to put the > ABI-checking fields into a sub-struct within the magic block. Okay, I've rewritten the patch to understand how it works. It seems to work pretty well. I added separate fields for minor and major versions. -- regards, Andrei Lepikhov
Commits
-
Avoid mixing designated and non-designated field initializers.
- d66997dfe8fe 18.0 landed
-
Use PG_MODULE_MAGIC_EXT in our installable shared libraries.
- 55527368bd07 18.0 landed
-
Introduce PG_MODULE_MAGIC_EXT macro.
- 9324c8c58065 18.0 landed