Use XLOG_CONTROL_FILE macro everywhere?
Anton A. Melnikov <a.melnikov@postgrespro.ru>
From: "Anton A. Melnikov" <a.melnikov@postgrespro.ru>
To: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2024-04-19T03:50:39Z
Lists: pgsql-hackers
Attachments
- 0001-Use-XLOG_CONTROL_FILE-macro-everywhere-in-C-code.patch (text/x-patch) patch 0001
Hello! There is a macro XLOG_CONTROL_FILE for control file name defined in access/xlog_internal.h And there are some places in code where this macro is used like here https://github.com/postgres/postgres/blob/84db9a0eb10dd1dbee6db509c0e427fa237177dc/src/bin/pg_resetwal/pg_resetwal.c#L588 or here https://github.com/postgres/postgres/blob/84db9a0eb10dd1dbee6db509c0e427fa237177dc/src/common/controldata_utils.c#L214 But there are some other places where the control file name is used as text string directly. May be better use this macro everywhere in C code? The patch attached tries to do this. Would be glad if take a look on it. With the best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company
Commits
-
Use XLOG_CONTROL_FILE macro consistently for control file name.
- 173c97812ffc 18.0 landed
-
Doc: Update link to the mentioned subsection
- 84db9a0eb10d 17.0 cited