Horton

Re: language cleanups in code and docs

David Steele <david@pgmasters.net>

View thread View on postgr.es
From: David Steele <david@pgmasters.net>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
Date: 2020-07-08T21:19:41Z
Lists: pgsql-hackers 
On 7/8/20 5:17 PM, Alvaro Herrera wrote:
> On 2020-Jul-08, David Steele wrote:
> 
>> On 7/8/20 4:39 PM, Andres Freund wrote:
> 
>> I think this phrasing in the original/updated version is pretty awkward:
>>
>> +  A standby server that cannot be connected to until it is promoted to a
>> +  primary server is called a ...
> 
> Yeah.
> 
>> How about:
>>
>> + A standby server that must be promoted to a primary server before
>> + accepting connections is called a ...
> 
> How about just reducing it to "A standby server that doesn't accept
> connection is called a ..."?  We don't really need to explain that if
> you do promote the standby it will start accept connections -- do we?
> It should be pretty obvious if you promote a standby, it will cease to
> be a standby in the first place.  This verbiage seems excessive.

Works for me.

Regards,
-- 
-David
david@pgmasters.net

Commits

  1. Replace remaining uses of "whitelist".

  2. pgindent: whitelist/blacklist -> additional/excluded.

  3. Rename "enum blacklist" to "uncommitted enums".

  4. code: replace most remaining uses of 'master'.

  5. docs: replace 'master process' with 'supervisor process' where appropriate.

  6. docs: replace 'master' with 'root' where appropriate.

  7. docs: replace 'master' with 'primary' where appropriate.

  8. code: replace 'master' with 'leader' where appropriate.

  9. code: replace 'master' with 'primary' where appropriate.

  10. tap tests: replace 'master' with 'primary'.