Horton

Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows

Heikki Linnakangas <hlinnaka@iki.fi>

View thread View on postgr.es
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Vladlen Popolitov <v.popolitov@postgrespro.ru>, Michael Paquier <michael@paquier.xyz>, Andrew Kane <andrew@ankane.org>, Nathan Bossart <nathandbossart@gmail.com>, pgsql-hackers@postgresql.org
Date: 2024-12-25T17:25:18Z
Lists: pgsql-hackers 
On 25/12/2024 18:34, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka@iki.fi> writes:
>> Ok, committed that, thanks1
> 
> The question this patch brings to my mind is whether libpgport
> doesn't need the same treatment.

Good point. Yes it does.

I tested that by adding a dummy call to COMP_CRC32C() in a test module, 
and letting cirrus CI build it:

[17:10:32.715] dummy_index_am.c.obj : error LNK2001: unresolved external 
symbol pg_comp_crc32c

Committed the same fix for libpqport.

-- 
Heikki Linnakangas
Neon (https://neon.tech)

Commits

  1. meson: Export all libcommon functions in Windows builds