Horton

Re: strange error reporting

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2021-05-03T10:08:04Z
Lists: pgsql-hackers 
On 21.01.21 02:33, Tom Lane wrote:
>>> I'd be inclined to spell it "connection to server at ... failed",
>>> but that sort of wording is surely also possible.
> 
>> "connection to server" rather than "connection to database" works for
>> me; in fact, I think I like it slightly better.
> 
> If I don't hear any other opinions, I'll change these messages to
> 
> "connection to server at socket \"%s\" failed:"
> "connection to server at \"%s\" (%s), port %s failed:"
> 
> (or maybe "server on socket"?  "at" sounds right for the IP address
> case, but it feels a little off in the socket pathname case.)

I was just trying some stuff with PG14, which led me to this thread.

I find these new error messages to be more distracting than before in 
some cases.  For example:

PG13:

clusterdb: error: could not connect to database typo: FATAL:  database 
"typo" does not exist

PG14:

clusterdb: error: connection to server on socket "/tmp/.s.PGSQL.65432" 
failed: FATAL:  database "typo" does not exist

Throwing the socket address in there seems a bit distracting and 
misleading, and it also pushes off the actual information very far to 
the end.  (Also, in some cases the socket path is very long, making the 
actual information even harder to find.)  By the time you get to this 
error, you have already connected, so mentioning the server address 
seems secondary at best.

Commits

  1. pgbench: Remove dead code

  2. Report the true database name on connection errors

  3. Avoid redundantly prefixing PQerrorMessage for a connection failure.

  4. Improve new wording of libpq's connection failure messages.