Horton

Re: pg_upgrade should truncate/remove its logs before running

Andrew Dunstan <andrew@dunslane.net>

View thread View on postgr.es
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, Justin Pryzby <pryzby@telsasoft.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Daniel Gustafsson <daniel@yesql.se>, Bruce Momjian <bruce@momjian.us>, pgsql-hackers@lists.postgresql.org
Date: 2022-02-07T00:47:32Z
Lists: pgsql-hackers 

> On Feb 6, 2022, at 7:39 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> Michael Paquier <michael@paquier.xyz> writes:
>>> On Sun, Feb 06, 2022 at 08:32:59AM -0500, Andrew Dunstan wrote:
>>> But the commit really shouldn't have happened until we know that most
>>> buildfarm owners have installed it. It should have waited wait not just
>>> for the release but for widespread deployment. Otherwise we will just
>>> lose any logging for an error that might appear.
> 
>> Would it be better if I just revert the change for now then and do it
>> again in one/two weeks?
> 
> I don't see a need to revert it.
> 
> I note, though, that there's still not been any email to the buildfarm
> owners list about this update.
> 
>  

It’s stuck in moderation 

Cheers

Andrew

Commits

  1. pg_upgrade: Move all the files generated internally to a subdirectory