Re: Add index scan progress to pg_stat_progress_vacuum
Sami Imseih <simseih@amazon.com>
From: "Imseih (AWS), Sami" <simseih@amazon.com>
To: Andres Freund <andres@anarazel.de>
Cc: Nathan Bossart <nathandbossart@gmail.com>, Peter Geoghegan <pg@bowt.ie>, "Bossart, Nathan" <bossartn@amazon.com>, Justin Pryzby <pryzby@telsasoft.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Masahiko Sawada <sawada.mshk@gmail.com>
Date: 2022-04-05T16:42:28Z
Lists: pgsql-hackers
> I nevertheless think that's not acceptable. The whole premise of the progress > reporting infrastructure is to be low overhead. It's OK to require locking to > initialize parallel progress reporting, it's definitely not ok to require > locking to report progress. Fair point. > Why isn't the obvious thing to do here to provide a way to associate workers > with their leaders in shared memory, but to use the existing progress fields > to report progress? Then, when querying progress, the leader and workers > progress fields can be combined to show the overall progress? The original intent was this, however the workers can exit before the command completes and the worker progress data will be lost. This is why the shared memory was introduced. This allows the worker progress to persist for the duration of the command. Regards, Sami Imseih Amazon Web Services.
Commits
-
Report index vacuum progress.
- 46ebdfe164c6 17.0 landed
-
Add new parallel message type to progress reporting.
- f1889729dd3a 17.0 landed
-
Remove MaxBackends variable in favor of GetMaxBackends() function.
- aa64f23b0292 15.0 cited