Horton

Re: [Proposal] Global temporary tables

曾文旌 (义从) <wenjing.zwj@alibaba-inc.com>

View thread
From: 曾文旌 <wenjing.zwj@alibaba-inc.com>
To: tushar <tushar.ahuja@enterprisedb.com>
Cc: Prabhat Sahu <prabhat.sahu@enterprisedb.com>, Pavel Stehule <pavel.stehule@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Konstantin Knizhnik <k.knizhnik@postgrespro.ru>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, "蔡松露(子嘉)" <zijia@taobao.com>, "Cai, Le" <le.cai@alibaba-inc.com>, "萧少聪(铁庵)" <shaocong.xsc@alibaba-inc.com>
Date: 2020-03-31T04:16:31Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. PageAddItemExtended(): Add LP_UNUSED assertion.

  2. Remove temporary files after backend crash

  3. Fix comment in indexing.c

  4. Fix failure to ignore leftover temp tables after a server crash.


> 2020年3月27日 下午5:21，tushar <tushar.ahuja@enterprisedb.com> 写道：
> 
> On 3/27/20 10:55 AM, 曾文旌 wrote:
>>> Hi Wenjing,
>>> This patch(gtt_v21_pg13.patch) is not applicable on PG HEAD, I hope you have prepared the patch on top of some previous commit. 
>>> Could you please rebase the patch which we can apply on HEAD ?
>> Yes, It looks like the built-in functions are in conflict with new code.
>> 
>> 
> This error message looks wrong  to me-
> 
> postgres=# reindex table concurrently t ;
> ERROR:  cannot create indexes on global temporary tables using concurrent mode
> postgres=# 
> 
> Better message would be-
> 
> ERROR:  cannot reindex global temporary tables concurrently
> 
I found that the local temp table automatically disables concurrency mode.
so, I made some improvements, The reindex GTT behaves the same as the local temp table.


Wenjing



> 
> -- 
> regards,tushar
> EnterpriseDB  https://www.enterprisedb.com/ <https://www.enterprisedb.com/>
> The Enterprise PostgreSQL Company