Re: json(b)_to_tsvector with numeric values

Teodor Sigaev <teodor@sigaev.ru>

From: Teodor Sigaev <teodor@sigaev.ru>
To: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Arthur Zakirov <a.zakirov@postgrespro.ru>, Oleg Bartunov <obartunov@postgrespro.ru>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-04-07T18:05:21Z
Lists: pgsql-hackers
Thank you, pushed with some editorization

Dmitry Dolgov wrote:
>> On 7 April 2018 at 17:09, Teodor Sigaev <teodor@sigaev.ru> wrote:
>>>> See workable sketch for parsing jsonb flags and new worker variant.
>>>
>>>
>>> Yep, thanks for the sketch. Here is the new version of patch, does it look
>>> close to what you have in mind?
>>
>>
>> Patch looks good except error messaging, you took it directly from sketch
>> where I didn't spend time for it. Please, improve. elog() should be used
>> only for impossible error, whereas user input could contins mistakes.
> 
> I assume what you mean is that for user input errors we need to use ereport.
> Indeed, thanks for noticing. I've replaced all elog except the last one, since
> it actually describes an impossible situation, when we started to read an
> array, but ended up having something else instead WJB_END_ARRAY.
> 

-- 
Teodor Sigaev                      E-mail: teodor@sigaev.ru
                                       WWW: http://www.sigaev.ru/


Commits

  1. Add json(b)_to_tsvector function