Horton

MSVC compilers complain about snprintf

Andrew Dunstan <andrew.dunstan@2ndquadrant.com>

View thread View on postgr.es
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-10-17T21:27:14Z
Lists: pgsql-hackers 
The MSVC compilers are whingeing about recent changes in snprintf.c:


    src\port\snprintf.c(1051): warning C4146: unary minus operator
    applied to unsigned type, result still unsigned


The line in question reads:

    uvalue = -(unsigned long long) value;

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Disable MSVC warning caused by recent snprintf.c changes

  2. Ensure that snprintf.c's fmtint() doesn't overflow when printing INT64_MIN.