Re: CI: Add task that runs pgindent
Peter Eisentraut <peter@eisentraut.org>
From: Peter Eisentraut <peter@eisentraut.org>
To: Jelte Fennema-Nio <me@jeltef.nl>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>
Date: 2025-10-21T17:39:39Z
Lists: pgsql-hackers
On 21.10.25 14:19, Jelte Fennema-Nio wrote: > At PGConf.dev 2025 one thing that came up in the "Scaling PostgreSQL > Development" unconference session is that new hackers don't know all the > details of our development flow by heart yet. Of course it's documented > on the wiki, but even if they find the relevant wiki pages they often > still miss/forget things. One of the things they often forget is > formatting their code. The consensus at that session was that it was > probably worth adding a CI task for this to nudge newcomers to indent > their code. Good idea. Additional suggestions: Maybe there is a way to cache the pg_bsd_indent build. In my testing, the configure and build steps each take 1/3 of the build time. Could be worth it. Also run the git whitespace check: git diff-tree --check `git hash-object -t tree /dev/null` HEAD