Horton
Menu

Re: Order changes in PG16 since ICU introduction

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Sandro Santilli <strk@kbt.io>, Tom Lane <tgl@sss.pgh.pa.us>, Regina Obe <lr@pcorp.us>, pgsql-hackers@lists.postgresql.org, Jeff Davis <pgsql@j-davis.com>
Date: 2023-05-11T11:07:53Z
Lists: pgsql-hackers

Attachments

On 09.05.23 10:25, Alvaro Herrera wrote:
> On 2023-Apr-24, Peter Eisentraut wrote:
> 
>> The GUC settings lc_collate and lc_ctype are from a time when those locale
>> settings were cluster-global.  When we made those locale settings
>> per-database (PG 8.4), we kept them as read-only.  As of PG 15, you can use
>> ICU as the per-database locale provider, so what is being attempted in the
>> above example is already meaningless before PG 16, since you need to look
>> into pg_database to find out what is really happening.
>>
>> I think we should just remove the GUC parameters lc_collate and lc_ctype.
> 
> I agree with removing these in v16, since they are going to become more
> meaningless and confusing.

Here is my proposed patch for this.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Introduce "builtin" collation provider.

  2. ICU: do not convert locale 'C' to 'en-US-u-va-posix'.

  3. initdb: change default --locale-provider back to libc.

  4. CREATE DATABASE: make LOCALE apply to all collation providers.

  5. Remove read-only server settings lc_collate and lc_ctype

  6. ICU: use uloc_getDefault() for initdb.

  7. Doc fixes for commit 1e16af8ab5.

  8. Doc: fix some rendering problems in the PDF docs build.

  9. Doc improvements for language tags and custom ICU collations.

  10. ICU: check for U_STRING_NOT_TERMINATED_WARNING.

  11. Reduce icu_validation_level default to WARNING.

  12. Revert "ICU: do not convert locale 'C' to 'en-US-u-va-posix'."

  13. Fix initdb --no-locale.

  14. Avoid character classification in regex escape parsing.