Horton
Menu

Re: Regression in statement locations

David Steele <david@pgbackrest.org>

View thread
From: David Steele <david@pgbackrest.org>
To: Sami Imseih <samimseih@gmail.com>, Michael Paquier <michael@paquier.xyz>
Cc: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>, jian he <jian.universality@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2025-05-20T14:04:20Z
Lists: pgsql-hackers 
On 5/20/25 07:34, Sami Imseih wrote:
> Tested the patch and it looks good to me.
> 
> Not that I thought it would fail, but I also confirmed the pgaudit case
> works as expected.

I also tested and everything looks good with the patch.

I did a careful examination of the remaining diffs (there are quite a 
few) and in every case I consider them to be beneficial, i.e. they make 
the output more targeted and readable.

I did not do a real code review, but I did notice that the test table 
column is called weird_name as in our tests. I would argue that since it 
is missing the quotes and space it is not really all that weird and 
should maybe get a normal name so developers in the future don't wonder 
what is weird about it.

Thank you for this improvement and the quick fix!

Regards,
-David

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix regression with location calculation of nested statements